Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from goblin #4624

Merged
merged 8 commits into from
Dec 30, 2024
Merged

Migrate away from goblin #4624

merged 8 commits into from
Dec 30, 2024

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 commented Dec 27, 2024

it's unmaintained for 3 years and go provides good native features

@qwerty287 qwerty287 added refactor delete or replace old code tests related to tests or other things CI check before merge labels Dec 27, 2024
@qwerty287 qwerty287 marked this pull request as ready for review December 27, 2024 18:11
@qwerty287 qwerty287 requested a review from a team December 27, 2024 18:11
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Dec 27, 2024

Deployment of preview was torn down

@xoxys
Copy link
Member

xoxys commented Dec 28, 2024

@qwerty287 Can you resolve the conflicts? Do you have any idea how to compare the overall test coverage before and after this change? I would like to check if we lost something.

@qwerty287
Copy link
Contributor Author

There shouldn't be a loss. I converted all usages and tests to go's native feature or the assert library we were using as well

@xoxys
Copy link
Member

xoxys commented Dec 28, 2024

In general I trust you :) But I would still like to see some coverage statistics. Im wondering why we dont see a coverage report on this PR.

@qwerty287
Copy link
Contributor Author

Probably because the test workflow didn't succeed yet. I'll look into it, but not sure if that will be today

@xoxys
Copy link
Member

xoxys commented Dec 28, 2024

No rush. Thanks for working on such boring tasks!

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.24%. Comparing base (828298b) to head (ae85552).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4624   +/-   ##
=======================================
  Coverage   28.24%   28.24%           
=======================================
  Files         400      400           
  Lines       28232    28232           
=======================================
  Hits         7974     7974           
  Misses      19552    19552           
  Partials      706      706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit afa6dee into woodpecker-ci:main Dec 30, 2024
7 checks passed
@qwerty287 qwerty287 deleted the no-goblin branch December 30, 2024 06:08
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 30, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code tests related to tests or other things CI check before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants