-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate away from goblin #4624
Migrate away from goblin #4624
Conversation
Deployment of preview was torn down |
@qwerty287 Can you resolve the conflicts? Do you have any idea how to compare the overall test coverage before and after this change? I would like to check if we lost something. |
There shouldn't be a loss. I converted all usages and tests to go's native feature or the |
In general I trust you :) But I would still like to see some coverage statistics. Im wondering why we dont see a coverage report on this PR. |
Probably because the test workflow didn't succeed yet. I'll look into it, but not sure if that will be today |
No rush. Thanks for working on such boring tasks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4624 +/- ##
=======================================
Coverage 28.24% 28.24%
=======================================
Files 400 400
Lines 28232 28232
=======================================
Hits 7974 7974
Misses 19552 19552
Partials 706 706 ☔ View full report in Codecov by Sentry. |
it's unmaintained for 3 years and go provides good native features