Add AMD Support #173
Add AMD Support #173
Conversation
|
@wookayin |
I'm not super familiar with mockito, but I've started looking into this. |
| @@ -612,6 +618,8 @@ def _wrapped(*args, **kwargs): | |||
| gpu_stat = InvalidGPU(index, "((Unknown Error))", e) | |||
| except N.NVMLError_GpuIsLost as e: | |||
| gpu_stat = InvalidGPU(index, "((GPU is lost))", e) | |||
| except Exception as e: | |||
There was a problem hiding this comment.
Should we raise the N.NVMLError_Unknown Error for consistency?
There was a problem hiding this comment.
ps: we can catch NVMLError instead of Base Exception, since you may ignore some python native errors
| super().__init__(self.message) | ||
|
|
||
|
|
||
| class NVMLError_Unknown(Exception): |
There was a problem hiding this comment.
Should these NVMLError_xxx inherit NVMLError?
| except (ImportError, SyntaxError, RuntimeError) as e: | ||
| _rocmi = sys.modules.get("rocmi", None) | ||
|
|
||
| raise ImportError( |
There was a problem hiding this comment.
Should we make this a dedicated NVMLError subclass?
Fixes #137
Design
To do this I duplicate the
pynvmlinterface already used by gpustat in a wrapper around rocmi and dynamically import the correct library based on what hardware is present.Current Status
The base functionality is currently working:
Remaining Tasks