-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 경매는 재고보다 많은 양의 사용자 요청을 처리할 수 없다. #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- submitBid에 전달된 auctionId가 유효한지 검증한다. - 유효하지 않은 경우 A011 에러가 발생한다.
- 남은 재고보다 더 많은 수량을 입찰하려는 경우를 검증한다. - 인당 구매 수량 제한을 벗어나는지 검증한다. - 경매 입찰 요청 수량 검증에 대한 A014 에러를 추가한다.
- 경매 재고보다 많은 수량을 입찰(구매)하려는 경우 예외가 발생 - 인당 구매 제한 수량보다 많은 수량을 입찰(구매)하려는 경우 예외가 발생
yudonggeun
previously approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋아요
@@ -22,7 +22,7 @@ public class Auction { | |||
@Builder | |||
private Auction(final ZonedDateTime startedAt, final Long sellerId, final String productName, | |||
final long originPrice, | |||
final int stock, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long 예리한데 👍
minseok-oh
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More
close #58