feat: 판매자가 등록한 경매의 정책을 변경할 수 있다. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 수정 요청을 하는 판매자 정보를 나타내는 sellerId를 추가하였습니다.
- ErrorCode.A013 : 권한이 없는 판매자 요청 에러 - updateShowStock 추가 : 가격 노출 정책 변경 메서드 구현
- 변경하는 가격 노출 정책이 없는 경우(null) 무시한다. - UpdateAuctionCommand.isShowStock 타입 변경 boolean -> Boolean
- percentagePricePolicy 퍼샌트 가격 정책 - constantPricePolicy 절대값 가격 정책
- Auction#updatePricePolicy 구현 - updatePricePolicy 성공 테스트 - updatePricePolicy 무시 테스트 : 업데이트할 정책이 Null인 경우 정책을 변경하지 않는다.
- UpdateAuctionCommand 생성시 판매자 id가 Null이 아니어야한다.
- 코드 충돌로 인한 변경입니다.
# Conflicts: # src/main/java/com/wootecam/luckyvickyauction/core/auction/dto/UpdateAuctionCommand.java # src/main/java/com/wootecam/luckyvickyauction/global/exception/ErrorCode.java # src/test/java/com/wootecam/luckyvickyauction/core/auction/dto/UpdateAuctionCommandTest.java # src/test/java/com/wootecam/luckyvickyauction/core/auction/service/AuctionServiceTest.java
chhs2131
reviewed
Aug 13, 2024
Comment on lines
7
to
14
| static PricePolicy percentagePricePolicy(int discountRate) { | ||
| return new PercentagePricePolicy(discountRate); | ||
| } | ||
|
|
||
| static PricePolicy constantPricePolicy(int variationWidth) { | ||
| return new ConstantPricePolicy(variationWidth); | ||
| } | ||
| } |
There was a problem hiding this comment.
제공되는 팩토리 메서드가 생성이라는 것을 알 수 있게 create 등으로 시작하는 것은 어떨까용? (예를 들어 createPercentagePricePolicy)
현재는 괜찮지만 나중에 인터페이스에 메서드가 늘어나면 헷갈릴 수도 있을 것 같아요!
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More
충돌 해결 살짝 힘들었다.
close #39