[FE] Typography 템플릿 및 컴포넌트 구현 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nlom0218
approved these changes
Jul 14, 2023
| type Story = StoryObj<typeof Typography>; | ||
|
|
||
| const meta: Meta<typeof Typography> = { | ||
| title: 'INPUTS/Typography', |
There was a problem hiding this comment.
DATA DISPLAY 하위 폴더에 있으면 좋을 거 같아요!
| ${({ variant, fontSize, fontWeight, color, $style }) => css` | ||
| font-size: ${fontSize || FONT_STYLE.fontSize[variant]}; | ||
| font-weight: ${fontWeight || FONT_STYLE.fontWeight[variant]}; | ||
| color: ${color || '#000'}; |
There was a problem hiding this comment.
#000 대신 이미 상수화 한 color 객체에서 black 불러와 사용하면 어떨까요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
closed #35
구현 기능 및 변경 사항
스크린샷(선택)