Skip to content

Commit

Permalink
Refactor/#505 댓글 기능을 임시 중단하고 킬링파트 듣기 페이지의 디자인을 수정한다. (#526)
Browse files Browse the repository at this point in the history
* design: 반응형 디자인 수정

- 킬링파트 인터페이스 데스크탑 너비 314px로 고정
- SongDetailItem 전체 크기 모바일 padding 8px
- SongDetailItem 세로 중앙 정렬

* feat: 댓글 기능 임시적으로 중단
  • Loading branch information
cruelladevil authored Oct 19, 2023
1 parent 3bd7934 commit d8f8a6b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
10 changes: 7 additions & 3 deletions frontend/src/features/songs/components/KillingPartInterface.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { useEffect, useRef, useState } from 'react';
import { styled } from 'styled-components';
import CommentList from '@/features/comments/components/CommentList';
// NOTE: 댓글 기능 임시 중단
// import CommentList from '@/features/comments/components/CommentList';
import useVideoPlayerContext from '@/features/youtube/hooks/useVideoPlayerContext';
import Flex from '@/shared/components/Flex/Flex';
import Spacing from '@/shared/components/Spacing';
Expand All @@ -19,6 +20,8 @@ const DEFAULT_PART_ID = -1;

const KillingPartInterface = ({ killingParts, songId, memberPart }: KillingPartInterfaceProps) => {
const [nowPlayingTrack, setNowPlayingTrack] = useState(DEFAULT_PART_ID);
// NOTE: 댓글 기능 임시 중단
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const [commentsPartId, setCommentsPartId] = useState<KillingPart['id']>(DEFAULT_PART_ID);
const [isRepeat, setIsRepeat] = useState(false);
const { videoPlayer, playerState, seekTo, pause } = useVideoPlayerContext();
Expand Down Expand Up @@ -144,9 +147,10 @@ const KillingPartInterface = ({ killingParts, songId, memberPart }: KillingPartI
setNowPlayingTrack={setNowPlayingTrack}
setCommentsPartId={setCommentsPartId}
/>
{commentsPartId !== DEFAULT_PART_ID && (
{/* NOTE: 댓글 기능 임시 중단 */}
{/* {commentsPartId !== DEFAULT_PART_ID && (
<CommentList songId={songId} partId={commentsPartId} />
)}
)} */}
</Flex>
);
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ export const TrackList = styled.div`
display: flex;
flex-direction: column;
gap: 10px;
width: 314px;
@media (max-width: ${({ theme }) => theme.breakPoints.md}) {
width: 100%;
}
`;

const PartRegisterButton = styled.button`
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/features/songs/components/SongDetailItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ const SongDetailItem = forwardRef<HTMLDivElement, SongDetailItemProps>(
<Flex
$gap={16}
$md={{ $direction: 'column' }}
$xs={{ $css: { padding: '8px' } }}
$css={{ padding: '16px', background: '#121212c8', borderRadius: '8px' }}
>
<Flex $direction="column" $css={{ flex: '3 1 0' }}>
Expand Down Expand Up @@ -82,6 +83,8 @@ export default SongDetailItem;
const Container = styled.div`
display: flex;
flex-direction: column;
justify-content: center;
height: 100vh;
padding-top: ${({ theme: { headerHeight } }) => headerHeight.desktop};
Expand Down

0 comments on commit d8f8a6b

Please sign in to comment.