홈 화면 서스펜스 범위 재지정 및 셀렉트 컴포넌트 리팩터링 #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
게시글 목록에서 셀렉트 밖을 누르면 셀렉트가 닫히도록 구현
|
⚡️ Lighthouse report!
|
inyeong-kang
approved these changes
Nov 13, 2023
| const handelOptionChange = (option: SortingOptionType) => { | ||
| setSelectedOption(option); | ||
| }; | ||
| export const Disable = () => { |
There was a problem hiding this comment.
사소한 건데 Disabled 로 해주실 수 있나요 ㅎㅎ
| import * as S from './style'; | ||
|
|
||
| interface PostListFetcherProps { | ||
| focusTopContent: () => void; |
There was a problem hiding this comment.
이벤트 핸들러 함수는 handle-- prefix 붙이는거 어떠신가용
| const handleCloseClick = (event: MouseEvent<HTMLDivElement>) => { | ||
| if (!selectRef.current) return; | ||
|
|
||
| const modalBoundary = selectRef.current.getBoundingClientRect(); |
There was a problem hiding this comment.
오 getBoundingClientRect 는 처음 알았네요! viewport를 기준으로 위치를 계산해서 반환하는 함수군요👍
| isDisabled = false, | ||
| ...rest | ||
| }: SelectProps<T>) { | ||
| const optionKeyList = Object.keys(optionList) as T[]; | ||
| const [isOpen, setIsOpen] = useState(false); | ||
|
|
||
| const toggleOpen = () => { |
|
fe-리뷰완 |
chsua
approved these changes
Nov 14, 2023
| toggleSelect: toggleSortingSelect, | ||
| selectRef: sortingSelectRef, | ||
| handleCloseClick: handleSortingClose, | ||
| } = useSelect<PostSorting>(postOption.sorting); |
| </S.SkeletonWrapper> | ||
| } | ||
| > | ||
| <PostListFetcher handleFocusTopContent={handleFocusTopContent} /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
close: #839
📝 작업 요약
⏰ 소요 시간
🔎 작업 상세 설명
이전 화면
2023-11-08.5.09.41.mov
바꾼 화면
2023-11-09.10.14.50.mov
셀렉트 닫히는 모습
게시글 목록 컨테이너에 클릭 이벤트를 걸어서 게시글 목록 밖을 클릭했을 때는 닫히지 않아요. 그렇지만 저는 이 정도면 만족해서 PR 올립니다
2023-11-09.10.16.28.mov