-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 페어 목록 리스트 구현 #117
[FE] 페어 목록 리스트 구현 #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨어요~~~~ 디자인 잘 해주셨네요!!!👍
const [isOpen, setIsOpen] = useState(false); | ||
|
||
const onCopy = () => { | ||
window.navigator.clipboard.writeText(roomCode); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
window 를 생략할수도 있을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생락하면 계속 오류가 발생하더라구요 ㅠㅠ
일단은 이대로 유지하겠습니다 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요, 파란! 🟦
디자인 측면에서 작은 리뷰를 달았는데 지금 단계에서 반영할 필요는 없을 것 같아 우선 Approve
드립니다 😊
고생 많으셨어요! 👏👏
} | ||
|
||
const Header = ({ isOpen }: HeaderProps) => ( | ||
<S.Layout icon={<IoPeople color={theme.color.primary[500]} />} title={isOpen ? '페어' : ''} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희 디자인이 닫혀 있는 상태가 기본이 되도록 변경된 만큼, 사이드 바에 마우스를 올리면 열 수 있다는 표시가 들어가는 것도 좋을 것 같다는 생각이에요. 피그마 디자인처럼 닫혀 있는 상태에서는 아이콘이 >
화살표로 변경되는 건 어떤가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다! 👍
@@ -0,0 +1,29 @@ | |||
import styled from 'styled-components'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희 피그마 시안에는 border
가 있는데 제공해 주신 영상은 피그마 시안과 다른 것처럼 보여요. 혹시 다르게 디자인이 된 이유가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isOpen때 border가 조금 짧아서 보류하고 있었어요. 반영했습니다 😊
연관된 이슈
구현한 기능
페어 목록 리스트 구현
상세 설명
마우스를 올리면 open, 마우스 내리면 close
2024-07-24.9.50.11.mov