-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] 페어룸 삭제 기능 구현 #753
[BE] 페어룸 삭제 기능 구현 #753
Conversation
기존 페어룸 조회 기능에 삭제된 페어룸을 검증하는 로직도 추가함.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@disable 제거하구 커밋 참고해서 코드 변경 부탁드려요!
@@ -115,6 +116,7 @@ void createReferenceLink(final String url, String accessCodeText, String categor | |||
.post("/api/" + accessCodeText + "/reference-link"); | |||
} | |||
|
|||
@Disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저거 실패하는 테스트 id가 하드코딩돼서 문제가 된 거 였어요
커밋
여기서 디스애이블 지우면 ci 터질 거 같으니 요 커밋참고해서 수정해주세요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 바로 반영하겠습니다!
@@ -74,4 +74,11 @@ ResponseEntity<List<PairRoomMemberResponse>> getPairRooms( | |||
@ApiResponse(responseCode = "200", description = "페어룸 존재 여부", content = @Content(mediaType = MediaType.APPLICATION_JSON_VALUE, | |||
schema = @Schema(implementation = PairRoomExistResponse.class))) | |||
ResponseEntity<PairRoomExistResponse> pairRoomExists(String accessCode); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
문서화 구웃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
끼욧
COMPLETED, | ||
DELETE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mysql 컬럼이 현재 enum으로 되어 있어서 변경해줘야 할 거 같은데 그건 제가 하겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니당!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 생각해보니까 delete 보나 deleted가 더 좋을 거 같아요..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다!!
수고하셨어요 켈리 👍👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
간단하게 코멘트 하나만 남겼습니다.
@@ -91,6 +92,21 @@ void throw_exception_when_find_not_exist_access_code() { | |||
.isExactlyInstanceOf(PairRoomNotFoundException.class); | |||
} | |||
|
|||
@Test | |||
@Transactional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 안붙히고 테스트 개선 안될가요?
연관된 이슈
구현한 기능
상세 설명
논리 삭제 방식으로 페어룸 삭제 API를 구현하였습니다.
추가로 전체 테스트를 돌리면
레퍼런스 링크를 삭제하는 요청
테스트가 실패하는 이슈가 있습니다. 해당 테스트를 단일, 혹은 컨트롤러 테스트를 동시에 실행하면 문제가 없지만레퍼런스 링크 서비스 테스트
+ 실패하는 해당 테스트 + 다른 컨트롤러 테스트 이렇게 세가지를 함께 실행하면 테스트가 실패하는것으로 보입니다.에러 로그는 "카테고리 링크가 존재하지 않다"고 나오는데 아마 테스트 초기화 과정에서 실행 순서에 의해 꼬인거 같습니다. 지금 몸상태가 좋지 않아 빠르게 해결이 힘들거 같아 우선 비활성화 후 PR 보냅니다.