[BE] 페어룸을 생성할 때 미션 링크 저장 #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiHyeonL
approved these changes
Oct 11, 2024
koust6u
requested changes
Oct 11, 2024
| @@ -187,7 +193,7 @@ void find_rooms_by_member() { | |||
| pairRoomService.savePairRoom(pairRoomCreateRequest, null); | |||
|
|
|||
| final PairRoomCreateRequest deletePairRoomCreateRequest = new PairRoomCreateRequest("레디", "잉크", 1, 1, | |||
| PairRoomStatus.DELETED.name()); | |||
| "https://missionUrl.xxx", PairRoomStatus.DELETED.name()); | |||
| @@ -43,16 +44,24 @@ public class PairRoomEntity extends BaseTimeEntity { | |||
| @Column(name = "DRIVER", nullable = false) | |||
| private String driver; | |||
|
|
|||
| @Column(name = "MISSION_URL", nullable = false) | |||
There was a problem hiding this comment.
[질문]
요 미션없이 페어룸 시작하기 하면 이건 어떻게 되나요?
There was a problem hiding this comment.
PairRoomCreateRequest 에
@Schema(description = "미션 리포지토리 링크. '그냥 시작할래요'로 생성하면 빈 문자열")
@NotNull
String missionUrl,
description을 추가해두었는데 설명을 더 적어두어야 할 곳이 있다면 말씀해주세용
There was a problem hiding this comment.
미션 그냥 시작할래요하면 url에 null 넣는게 나아 보이는데 빈문자열 사용하신 이유가 있나요?
Comment on lines
+10
to
+12
| public MissionUrl(final String value) { | ||
| this.value = value; | ||
| } |
There was a problem hiding this comment.
미션 링크 검증은 DTO에서만 해도될지요? 고민해보면 좋을거같은데요.
코드로 보기엔 null값만 아니면 생성되는거 같은데 여기에 검증 기능 더 타이트하게 넣도 되지 않을까요?
reddevilmidzy
requested changes
Oct 11, 2024
| @@ -43,16 +44,24 @@ public class PairRoomEntity extends BaseTimeEntity { | |||
| @Column(name = "DRIVER", nullable = false) | |||
| private String driver; | |||
|
|
|||
| @Column(name = "MISSION_URL", nullable = false) | |||
There was a problem hiding this comment.
미션 그냥 시작할래요하면 url에 null 넣는게 나아 보이는데 빈문자열 사용하신 이유가 있나요?
| @@ -43,16 +44,24 @@ public class PairRoomEntity extends BaseTimeEntity { | |||
| @Column(name = "DRIVER", nullable = false) | |||
| private String driver; | |||
|
|
|||
| @Column(name = "MISSION_URL", nullable = false) | |||
Comment on lines
+28
to
+29
| @NotNull | ||
| String missionUrl, |
There was a problem hiding this comment.
빈값을 허용해야해서 @NotNull만 사용했습니다!
koust6u
approved these changes
Oct 11, 2024
reddevilmidzy
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
구현한 기능
페어룸 테이블에 미션 링크 추가
상세 설명
페어룸 생성할 때 미션 링크를 저장