-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: BindingFragment에서 analytics 가능하게 수정 #697
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
부지런하네요 해음
|
||
abstract class BindingFragment<T : ViewDataBinding>( | ||
@LayoutRes private val layoutRes: Int, | ||
) : Fragment() { | ||
private var _binding: T? = null | ||
protected val binding: T | ||
get() = requireNotNull(_binding) | ||
private val analyticsHelper: AnalyticsHelper by lazy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private로 해두면 BindingFragment를 상속받는 Fragment들이 analyticsHelper를 못쓸 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 친구도 hilt로 주입받아보는건 어떤가요 모듈 만들어놓은거로
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BindingActivity에도 이 코드가 있나요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hilt로 주입하려고 했는데 타입 파라미터를 알 수 없는 곳에는 못한다고 하네요ㅜㅡㅜ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BindingActivity에는 없습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
analyticsHelper에 있는 private 제거하겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋네요!!
🚩 연관 이슈
close #554
📝 작업 내용
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)