[차람] 회원가입 미션 1, 2단계 제출합니다. #10
Open
+326
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haeum808
requested changes
Oct 11, 2024
Comment on lines
+1
to
+2
| [*.{kt,kts}] | ||
| ktlint_function_naming_ignore_when_annotated_with=Composable |
| Text( | ||
| text = text, | ||
| fontSize = 14.sp, | ||
| modifier = modifier.padding(15.dp), |
There was a problem hiding this comment.
Button에 modifier를 주지 않은이유가 궁금합니다!
ConfirmButton이 Modifier를 주는데 Text가 가져가서요!
| label: String, | ||
| text: MutableState<String>, | ||
| onValueChange: (String) -> Unit = {}, | ||
| ) = SignUpTextField( |
| import nextstep.signup.ui.theme.SignupTheme | ||
|
|
||
| @Composable | ||
| fun SignUpPasswordTextField( |
There was a problem hiding this comment.
로그인할때 중복 사용을 대비해서 SignUpPasswordTextField -> PasswordTextField 어떤가요?
| visualTransformation: VisualTransformation = VisualTransformation.None, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| TextField( |
| onBackground = Color(0xFF1C1B1F), | ||
| onSurface = Color(0xFF1C1B1F), | ||
| */ | ||
| primary = Blue50, |
| <string name="welcome">Welcome to Compose \uD83D\uDE80</string> |
| isPasswordSame | ||
|
|
||
| Text( | ||
| modifier = Modifier.padding(bottom = 42.dp), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 해음
이번엔 리뷰어로 만나게 되었네요 ✋
리뷰잘부탁드려요