Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Gutenberg Video block from excerpt to hide VideoPress URLs #352

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Remove Gutenberg Video block from excerpt to hide VideoPress URLs #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
323f88d
fix: Remove Video block content from post excerpt
Feb 27, 2024
d9d8d04
test: Add new test to ensure video block is hidden
Feb 27, 2024
586a6be
refactor: Remove trailing white space
Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/WordPressShared/Utility/String+StripGutenbergContentForExcerpt.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ extension String {
return removingMatches(pattern: pattern, options: .caseInsensitive)
}

/// Strips Gutenberg VideoPress block.
/// Strips VideoPress references from Gutenberg VideoPress and Video blocks.
///
private func strippingGutenbergVideoPress() -> String {
let pattern = "(?s)\n?<!--\\swp:videopress/video?(.*?)wp:videopress/video\\s-->"
let pattern = "(?s)\n?<!--\\swp:video.*?(.*?)wp:video.*?\\s-->"

return removingMatches(pattern: pattern, options: .caseInsensitive)
}
Expand Down
9 changes: 9 additions & 0 deletions Tests/WordPressSharedTests/StringStripGutenbergContentForExcerptTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,13 @@ class StringStripGutenbergContentForExcerptTests: XCTestCase {

XCTAssertEqual(summary, expectedSummary)
}

func testStrippingGutenbergContentForExcerptWithVideoPress2() {
let content = "<p>Before</p>\n<!-- wp:video {\"guid\":\"AbCDe\",\"id\":5297} -->\n<figure class=\"wp-block-video\"><div class=\"wp-block-embed__wrapper\">\nhttps://videopress.com/v/AbCDe?resizeToParent=true&amp;cover=true&amp;preloadContent=metadata&amp;useAverageColor=true\n</div></figure>\n<!-- /wp:video -->\n<p>After</p>"
let expectedSummary = "<p>Before</p>\n<p>After</p>"

let summary = content.strippingGutenbergContentForExcerpt()

XCTAssertEqual(summary, expectedSummary)
}
}