Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WPImageSource and OHHTTPStubs dependency #360

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Jun 26, 2024

I removed the last WPImageSource usage from WordPress-iOS a few months ago – it's now down to only a couple of images loading systems, down from 10+.

WordPressShared now has no dependencies except for the ones used by CI:

    dependencies: [
        .package(url: "https://github.com/buildkite/test-collector-swift", from: "0.3.0"),
        // See https://github.com/erikdoe/ocmock/issues/500#issuecomment-1002700625
        .package(url: "https://github.com/realm/SwiftLint", exact: loadSwiftLintVersion())
    ],

  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@kean kean requested a review from jkmassel June 26, 2024 20:50
@kean kean force-pushed the task/remove-wpimagesource branch from 617b7a0 to 166f6a8 Compare June 26, 2024 20:55
Base automatically changed from task/remove-quick-dependency to trunk June 26, 2024 21:37
@kean kean merged commit 6e8a441 into trunk Jun 26, 2024
9 checks passed
@kean kean deleted the task/remove-wpimagesource branch June 26, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants