Remove readerNavigationController from ReaderCoordinator

wordpress-mobile · Sep 16, 2024 · dca86e8 · dca86e8
1 parent 72d768a
commit dca86e8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 20 deletions.
diff --git a/WordPress/Classes/System/SplitViewRootPresenter.swift b/WordPress/Classes/System/SplitViewRootPresenter.swift
@@ -268,7 +268,9 @@ final class SplitViewRootPresenter: RootViewPresenter {
 
     var readerTabViewController: ReaderTabViewController?
 
-    var readerCoordinator: ReaderCoordinator?
+    var readerCoordinator: ReaderCoordinator? {
+        ReaderCoordinator()
+    }
 
     var readerNavigationController: UINavigationController?
 

diff --git a/WordPress/Classes/ViewRelated/System/Coordinators/ReaderCoordinator.swift b/WordPress/Classes/ViewRelated/System/Coordinators/ReaderCoordinator.swift
@@ -2,16 +2,6 @@ import UIKit
 
 @objc
 class ReaderCoordinator: NSObject {
-    let readerNavigationController: UINavigationController
-
-    var failureBlock: (() -> Void)? = nil
-
-    @objc
-    init(readerNavigationController: UINavigationController) {
-        self.readerNavigationController = readerNavigationController
-        super.init()
-    }
-
     func showReaderTab() {
         RootViewCoordinator.sharedPresenter.showReaderTab()
     }
@@ -47,7 +37,6 @@ class ReaderCoordinator: NSObject {
     func showList(named listName: String, forUser user: String) {
         let context = ContextManager.sharedInstance().mainContext
         guard let topic = ReaderListTopic.named(listName, forUser: user, in: context) else {
-            failureBlock?()
             return
         }
 
@@ -103,13 +92,6 @@ class ReaderCoordinator: NSObject {
     }
 
     private func showPost(in detailViewController: ReaderDetailViewController) {
-
-        let postLoadFailureBlock = { [weak self, failureBlock] in
-            self?.readerNavigationController.popToRootViewController(animated: false)
-            failureBlock?()
-        }
-
-        detailViewController.postLoadFailureBlock = postLoadFailureBlock
         RootViewCoordinator.sharedPresenter.navigateToReader(detailViewController)
     }
 

diff --git a/WordPress/Classes/ViewRelated/System/WPTabBarController.m b/WordPress/Classes/ViewRelated/System/WPTabBarController.m
@@ -274,7 +274,7 @@ - (MySitesCoordinator *)mySitesCoordinator
 
 - (ReaderCoordinator *)readerCoordinator
 {
-    return [[ReaderCoordinator alloc] initWithReaderNavigationController:self.readerNavigationController];
+    return [[ReaderCoordinator alloc] init];
 }
 
 #pragma mark - Navigation Helpers