Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do full link selection fix only on 13.0 #12772

Merged

Conversation

SergioEstevao
Copy link
Contributor

Fixes #12626

To test:

  • Check the scenario referred in the ticket to see if the bug still happens

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on iOS 13.1 🎉

Note: Couldn't test on 13.0.

@SergioEstevao SergioEstevao merged commit f39a64b into release/13.5 Oct 28, 2019
@SergioEstevao SergioEstevao deleted the issue/12626_fix_aztec_text_view_link_click branch October 28, 2019 12:59
@designsimply
Copy link
Contributor

I tested with develop @ 625c1df8d0 on an iPhone 6S iOS 13.1.3 and couldn't get the app to crash after trying to add, remove, move links including dragging and dropping text with links or just links in the Aztec editor.

@koke
Copy link
Member

koke commented Oct 29, 2019

Sorry I got to this one late, but I'm still not sure about this fix. The original crash was also happening on 13.0, so this won't fix the crash for those users. I still think it's better to avoid the crash (which could lead to content loss in an editor context) rather than avoid a link UX bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants