Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused WPTableImageSource and its cache #21152

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Jul 20, 2023

Removes the unused code identified in the scope of #21120.
Turned out of the additional caches I found was not even used, yay.

To test:

  • Compiles

Regression Notes

  1. Potential unintended areas of impact: n/a
  2. What I did to test those areas of impact (or what existing automated tests I relied on): n/a
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kean kean added this to the Pending milestone Jul 20, 2023
@kean kean assigned guarani and staskus and unassigned guarani and staskus Jul 20, 2023
@kean kean requested review from guarani and staskus July 20, 2023 16:08
@kean kean unassigned guarani and staskus Jul 20, 2023
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21152-a6b8389
Version22.8
Bundle IDorg.wordpress.alpha
Commita6b8389
App Center BuildWPiOS - One-Offs #6441
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21152-a6b8389
Version22.8
Bundle IDcom.jetpack.alpha
Commita6b8389
App Center Buildjetpack-installable-builds #5469
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this dead code 👍

@kean kean merged commit 4fa6909 into trunk Jul 20, 2023
@kean kean deleted the task/remove-unused-image-source branch July 20, 2023 19:39
@guarani guarani mentioned this pull request Jul 21, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants