Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline Mode: Fix keyboard avoidance in submit button #23070

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Offline Mode: Fix keyboard avoidance in submit button #23070

merged 3 commits into from
Apr 24, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Apr 23, 2024

To test

Important

Make sure to check with "Sync Publishing" both ON and OFF

  • Select a post and tap "Publish" to open the prepublishing sheet
  • ✅ Verify that the "Publish" button and everything else is in place
  • Tap "Tags"
  • ✅ Verify that the keyboard appeared (must be enabled if in a simulator)
  • Tap "Back"
  • ✅ Verify that the "Publish" button is still in the same place (at the bottom)

Regression Notes

  1. Potential unintended areas of impact: Prepublishing Sheet
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 24.8 milestone Apr 23, 2024
@kean kean requested a review from momo-ozawa April 23, 2024 17:20
kean
kean commented Apr 23, 2024
View reviewed changes
WordPress/Classes/ViewRelated/Post/Prepublishing/DeprecatedPrepublishingViewController.swift
@@ -55,11 +54,14 @@ final class DeprecatedPrepublishingViewController: UIViewController, UITableView
let tableView = UITableView(frame: .zero, style: .plain)
private let footerSeparator = UIView()

private weak var titleField: UITextField?
let publishButton: NUXButton = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the changes made in the scope of the Offline Mode: Phase 1.

WordPress/Classes/ViewRelated/Post/Prepublishing/PrepublishingViewController.swift
tableView,
footerSeparator,
setupPublishButton()
tableView
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the footerSeparator for now because it was a bit buggy and it wasn't even needed considering the now larger height.

WordPress/Classes/ViewRelated/Post/Prepublishing/PrepublishingViewController.swift
view.addSubview(stackView)
stackView.translatesAutoresizingMaskIntoConstraints = false
view.pinSubviewToSafeArea(stackView)
let contentView = VStack {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal, but it once step closer to reworking it purely in SwiftUI.
I have a prototype, but I'd rather avoid making this large change for now.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23070-10948d1
Version24.7
Bundle IDorg.wordpress.alpha
Commit10948d1
App Center BuildWPiOS - One-Offs #9638
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23070-10948d1
Version24.7
Bundle IDcom.jetpack.alpha
Commit10948d1
App Center Buildjetpack-installable-builds #8681
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

momo-ozawa
momo-ozawa approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, tested feature flag enabled / disabled

@kean kean force-pushed the fix/prepublishing-view-height branch from 23698db to 10948d1 Compare April 24, 2024 13:02
@kean kean merged commit 7d16f0e into trunk Apr 24, 2024
24 checks passed
@kean kean deleted the fix/prepublishing-view-height branch April 24, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Assignees
No one assigned
Labels
[Type] Bug
Projects
None yet
Milestone
24.8
Development

Successfully merging this pull request may close these issues.
3 participants
@kean @wpmobilebot @momo-ozawa