Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: Enable FF #23617

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Sidebar: Enable FF #23617

merged 3 commits into from
Sep 20, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Sep 18, 2024

Enable FF for production.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the iPad label Sep 18, 2024
@kean kean added this to the 25.4 milestone Sep 18, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 18, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.4. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 18, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23617-9d94244
Version25.3
Bundle IDcom.jetpack.alpha
Commit9d94244
App Center Buildjetpack-installable-builds #9761
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 18, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23617-9d94244
Version25.3
Bundle IDorg.wordpress.alpha
Commit9d94244
App Center BuildWPiOS - One-Offs #10718
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean
Copy link
Contributor Author

kean commented Sep 19, 2024

"UI Tests (iPad): 29 tests have failed (29 distinct assertion failure(s) in total)"
I need to update them all 😞

@kean kean force-pushed the task/sidebar-enable-ff branch 2 times, most recently from e804ee3 to 641e4ac Compare September 19, 2024 14:37
Copy link
Contributor

@crazytonyli crazytonyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to fix UI tests sooner rather than later. Otherwise, the UI test runs on PR would waste time on testing the wrong things.

@@ -49,6 +49,8 @@ extension XCTestCase {
app.launchArguments.append(contentsOf: ["-ui-test-select-wpcom-site", selectWPComSite])
}

app.launchArguments.append(contentsOf: ["ff-override-Sidebar", "false"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this line would magically disable Sidebar for UI tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the idea. Not sure why it's not working.

@kean
Copy link
Contributor Author

kean commented Sep 19, 2024

It's probably best to fix UI tests sooner rather than later. Otherwise, the UI test runs on PR would waste time on testing the wrong things.

I don't know if we have the capacity to maintain tests on iPad. I guess it shouldn't be too hard to update, but it always take me way to much time to change and test anything there.

@kean kean enabled auto-merge September 20, 2024 15:04
@kean kean added this pull request to the merge queue Sep 20, 2024
Merged via the queue into trunk with commit a1dac98 Sep 20, 2024
24 checks passed
@kean kean deleted the task/sidebar-enable-ff branch September 20, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants