-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar: Enable FF #23617
Sidebar: Enable FF #23617
Conversation
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
"UI Tests (iPad): 29 tests have failed (29 distinct assertion failure(s) in total)" |
e804ee3
to
641e4ac
Compare
641e4ac
to
0d427b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably best to fix UI tests sooner rather than later. Otherwise, the UI test runs on PR would waste time on testing the wrong things.
@@ -49,6 +49,8 @@ extension XCTestCase { | |||
app.launchArguments.append(contentsOf: ["-ui-test-select-wpcom-site", selectWPComSite]) | |||
} | |||
|
|||
app.launchArguments.append(contentsOf: ["ff-override-Sidebar", "false"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this line would magically disable Sidebar for UI tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the idea. Not sure why it's not working.
I don't know if we have the capacity to maintain tests on iPad. I guess it shouldn't be too hard to update, but it always take me way to much time to change and test anything there. |
Enable FF for production.
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: