Fix UIColor primary

[kean]

RCA

In the previous version, UIColor.primary (custom property) meant the same as UIColor.brand (blue/green).

In the new version, UIAppColor.primary maps to UIColor.label, which is incorrect. In most places where UIColor.primary was replaced with UIAppColor.primary, the app now shows incorrect colors. For example, here are three areas I found during testing:

The fix isn't as straightforward because in some places – the ones I found so far – UIAppColor.primary replaced other colors like UIColor.appBarText. We don't want nav bar titles to be green or blue, so it had to be address it with more code changes.

To test:

I've reviewed a bunch of scenarios that used UIAppColor.primary, but didn't have to time to check everything. I hope if there are any other issues, they will eventually bubble up. To the very least, this PR should reduce the number of issues.

Future Changes

There is still a little bit of work left to review how the brand/tint/primary colors are used and how the colors are applied in the UI.

For Jetpack, the rule of thumb should be to use green color (UIAppColor.brand) only in places where it would otherwise be hard or impossible to tell that the control is a control. The main tint color for the Jetpack app (UIAppColor.tint) is black (UIColor.label).

I would also recommend removing UIAppColor.primary as it can be confused with Color.primary from SwiftUI.

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 25.4. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23621-cd8a5a4
	Version	25.3
	Bundle ID	org.wordpress.alpha
	Commit	cd8a5a4
	App Center Build	WPiOS - One-Offs #10735

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23621-cd8a5a4
	Version	25.3
	Bundle ID	com.jetpack.alpha
	Commit	cd8a5a4
	App Center Build	jetpack-installable-builds #9779

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[jkmassel]

Approved, and I snuck in a small fix for widgets

[kean]

The charts like "Insights" and "Subscribers" are designed to use these colors in both wpios and jpios to match wp.com. It is a current production behavior based on the customer feedback. The green color is not great for charts because it implies "growth" and can be confusing.

There seem to be an issue with the empty charts:

Let's make sure the changes match the current production behavior.

[jkmassel]

This should be resolved now, merging.