Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address a build failure in the tests because of unhandled XCTSkip #23635

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Sep 29, 2024

CI should be green.

Before — I haven't tracked down the PR/commit that introduced this (how did it pass CI?) the link there is just the first build I noticed.

image

After
image

@mokagio mokagio added this to the 25.5 milestone Sep 29, 2024
@mokagio mokagio added the Testing Unit and UI Tests and Tooling label Sep 29, 2024
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23635-787555b
Version25.4
Bundle IDcom.jetpack.alpha
Commit787555b
App Center Buildjetpack-installable-builds #9802
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23635-787555b
Version25.4
Bundle IDorg.wordpress.alpha
Commit787555b
App Center BuildWPiOS - One-Offs #10759
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@crazytonyli crazytonyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@crazytonyli crazytonyli added this pull request to the merge queue Sep 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2024
@crazytonyli crazytonyli added this pull request to the merge queue Sep 30, 2024
Merged via the queue into trunk with commit d6b149b Sep 30, 2024
26 checks passed
@crazytonyli crazytonyli deleted the mokagio/build-failures-20240930 branch September 30, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Unit and UI Tests and Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants