Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role to directory sync user #339

Merged
merged 5 commits into from
May 28, 2024
Merged

Add role to directory sync user #339

merged 5 commits into from
May 28, 2024

Conversation

ameesha
Copy link
Contributor

@ameesha ameesha commented May 22, 2024

Description

  • optional field to directory user

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@ameesha ameesha requested a review from a team as a code owner May 22, 2024 18:11
@ameesha ameesha requested a review from mattgd May 22, 2024 18:11
@ameesha ameesha requested review from a team, tribble and PavanKulkarni and removed request for a team May 22, 2024 19:39
@@ -2,5 +2,5 @@ package workos

const (
// Version represents the SDK version number.
Version = "v4.9.0"
Version = "v4.10.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do this in a separate PR for any other changes that may be included in the release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you an owner for the go sdk? i do it in 1 so that it doesn't require 2 owners checks (been blocked by this before)
but i'll grab whatever changes that were merged before this when i cut a release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm a Gopher, so can approve the bump whenever.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, just undone

@ameesha ameesha merged commit 05b9c36 into main May 28, 2024
2 checks passed
@ameesha ameesha deleted the add-role-to-dsync-user branch May 28, 2024 15:09
@ameesha ameesha mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants