PR feedback

workos/resources/directory_sync.py

@@ -1,7 +1,5 @@
 from typing import List, Optional, Literal
-from enum import Enum
 from workos.resources.workos_model import WorkOSModel
-from workos.typing.enums import EnumOrUntyped
 from workos.typing.literals import LiteralOrUntyped
 
 DirectoryState = Literal[

workos/resources/list.py

@@ -109,18 +109,24 @@ def auto_paging_iter(self):
                 data = []
 
 
-# add all possible generics of List Resource
-T = TypeVar("T", Organization, Directory, DirectoryGroup, DirectoryUser)
+ListableResource = TypeVar(
+    # add all possible generics of List Resource
+    "ListableResource",
+    Organization,
+    Directory,
+    DirectoryGroup,
+    DirectoryUser,
+)
 
 
 class ListMetadata(BaseModel):
     after: Optional[str] = None
     before: Optional[str] = None
 
 
-class ListPage(BaseModel, Generic[T]):
+class ListPage(BaseModel, Generic[ListableResource]):
     object: Literal["list"]
-    data: List[T]
+    data: List[ListableResource]
     list_metadata: ListMetadata
 
 
@@ -134,17 +140,17 @@ class Config:
         extra = "allow"
 
 
-class WorkOsListResource(BaseModel, Generic[T]):
+class WorkOsListResource(BaseModel, Generic[ListableResource]):
     object: Literal["list"]
-    data: List[T]
+    data: List[ListableResource]
     list_metadata: ListMetadata
 
     # These fields end up exposed in the types. Does we care?
     list_method: Callable = Field(exclude=True)
     list_args: ListArgs = Field(exclude=True)
 
-    def auto_paging_iter(self) -> Iterator[T]:
-        next_page: WorkOsListResource[T]
+    def auto_paging_iter(self) -> Iterator[ListableResource]:
+        next_page: WorkOsListResource[ListableResource]
 
         after = self.list_metadata.after
         order = self.list_args.order

workos/resources/organizations.py

@@ -5,7 +5,7 @@
 class OrganizationDomain(WorkOSModel):
     id: str
     organization_id: str
-    object: Literal["organization"]
+    object: Literal["organization_domain"]
     verification_strategy: Literal["manual", "dns"]
     state: Literal["failed", "pending", "legacy_verified", "verified"]
     domain: str