Skip to content

Commit

Permalink
Python SDK: Add 25 second default timeout to requests (#247)
Browse files Browse the repository at this point in the history
* Add 25 second default timeout to requests

* Update 404 response

* Make request timeout configuratble by end user

* Remove unused declaration
  • Loading branch information
awolfden authored Apr 3, 2024
1 parent 3de187a commit 5f4008f
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
1 change: 1 addition & 0 deletions workos/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
api_key = os.getenv("WORKOS_API_KEY")
client_id = os.getenv("WORKOS_CLIENT_ID")
base_api_url = "https://api.workos.com/"
request_timeout = 25
16 changes: 13 additions & 3 deletions workos/utils/request.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@
class RequestHelper(object):
def __init__(self):
self.set_base_api_url(workos.base_api_url)
self.set_request_timeout(workos.request_timeout)

def set_request_timeout(self, request_timeout):
self.request_timeout = request_timeout

def set_base_api_url(self, base_api_url):
"""Creates an accessible template for constructing the URL for an API request.
Expand Down Expand Up @@ -73,9 +77,13 @@ def request(

request_fn = getattr(requests, method)
if method == REQUEST_METHOD_GET:
response = request_fn(url, headers=headers, params=params)
response = request_fn(
url, headers=headers, params=params, timeout=self.request_timeout
)
else:
response = request_fn(url, headers=headers, json=params)
response = request_fn(
url, headers=headers, json=params, timeout=self.request_timeout
)

response_json = None
content_type = (
Expand All @@ -99,7 +107,9 @@ def request(
raise NotFoundException(response)
error = response_json.get("error")
error_description = response_json.get("error_description")
raise BadRequestException(response)
raise BadRequestException(
response, error=error, error_description=error_description
)
elif status_code >= 500 and status_code < 600:
raise ServerException(response)

Expand Down

0 comments on commit 5f4008f

Please sign in to comment.