Return User instead of MagicAuthChallenge response
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatascastro12
requested review from
maxdeviant
and removed request for
a team
This was referenced Aug 24, 2023
Merged
jonatascastro12
changed the title
jonatascastro12
changed the title
jonatascastro12
changed the title
User Response instead of MagicAuthChallenge eesponse
jonatascastro12
changed the title
User Response instead of MagicAuthChallenge eesponseUser instead of MagicAuthChallenge response
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## users #204 +/- ##
==========================================
- Coverage 88.37% 88.34% -0.04%
==========================================
Files 34 33 -1
Lines 1222 1218 -4
==========================================
- Hits 1080 1076 -4
Misses 142 142
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jonatascastro12
force-pushed
the
feature/usrld-734-add-sendmagicauthcode-to-python
branch
from
bb1932e
to
73bb1f5
Compare
jonatascastro12
force-pushed
the
feature/usrld-921-magic-auth-and-email-verification-response-returns-user
branch
from
a9a9d39
to
68e224f
Compare
jonatascastro12
force-pushed
the
feature/usrld-734-add-sendmagicauthcode-to-python
branch
from
73bb1f5
to
4a389d9
Compare
jonatascastro12
force-pushed
the
feature/usrld-921-magic-auth-and-email-verification-response-returns-user
branch
from
68e224f
to
d85277e
Compare
Base automatically changed from
feature/usrld-734-add-sendmagicauthcode-to-python
to
users
August 24, 2023 15:56
…ead of MagicAuthChallenge Response
jonatascastro12
force-pushed
the
feature/usrld-921-magic-auth-and-email-verification-response-returns-user
branch
from
d85277e
to
5653606
Compare
This was referenced Aug 25, 2023
jonatascastro12
deleted the
feature/usrld-921-magic-auth-and-email-verification-response-returns-user
branch
blairlunceford
added a commit
that referenced
this pull request
Nov 14, 2023
* Add `Users` client and `Users.create_user()` method (#191) * Add Users client and Users.create_user() method * Fix comment and format. * Get user. (#192) * Add `Users.list_users()` (#193) * Add `Users.list_users()` * Do not use f-string * Fix comment * Fix format * Remove User type, and other fields * Add add_user_to_organization and remove_user_to_organization methods (#195) * Add `Users.authenticate_with_magic_auth()` (#196) * Add authenticate_with_magic_auth * Update comment * Add `Users.authenticate_with_password()` (#197) * Add `Users.authenticate_with_password()` * Fix method * Update comment * Update test * Add `Users.authenticate_with_code()` (#198) * Add `Users.authenticate_with_token()` method * Rename method * Fix test * Add `Users.create_password_challenge()` method (#199) * Add `Users.complete_password_reset()` method (#200) * Add `Users.send_verification_email()` method (#201) * Add `Users.send_verification_email()` method * Fix Magic Auth challenge * Fix test * Add `Users.verify_email()` method (#202) * Add `Users.send_magic_auth_code()` method (#203) * Add `Users.send_magic_auth_code()` method * Fix test * Fix test 2 * Return `User` instead of `MagicAuthChallenge` response (#204) * Magic Auth and Email Verification response returns User Response instead of MagicAuthChallenge Response * Replace other magic_auth_challenge_id references * Add users.delete_user() method (#205) * Fix authenticate methods (#206) * Add `users.update_user_password()` method (#207) * Add `users.update_user()` method (#208) * Fix Verify Email Code method (#209) --------- Co-authored-by: Jônatas Santos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.