Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domain param from directories query #230

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ameesha
Copy link
Contributor

@ameesha ameesha commented Jan 16, 2024

Description

We no longer support querying directories by domain.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@ameesha ameesha requested a review from a team as a code owner January 16, 2024 16:52
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@dd203fd). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage        ?   86.49%           
=======================================
  Files           ?       31           
  Lines           ?     1296           
  Branches        ?        0           
=======================================
  Hits            ?     1121           
  Misses          ?      175           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ameesha ameesha requested review from a team, tribble, PavanKulkarni, lukemorales and blairlunceford and removed request for a team January 16, 2024 16:57
Copy link
Contributor

@PaulAsjes PaulAsjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@mattgd mattgd added the breaking change Contains a breaking change label May 29, 2024
@mattgd mattgd self-assigned this Jun 6, 2024
@mattgd mattgd force-pushed the remove-domain-param-from-directories branch from 95cc4fe to 9fae9a4 Compare July 30, 2024 20:57
@mattgd mattgd changed the base branch from main to beta-5.0 July 30, 2024 20:57
@mattgd mattgd merged commit c3af80d into beta-5.0 Jul 30, 2024
5 checks passed
@mattgd mattgd deleted the remove-domain-param-from-directories branch July 30, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Contains a breaking change
Development

Successfully merging this pull request may close these issues.

5 participants