Add async support for organizations #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgd
commented
Aug 14, 2024
| @@ -1,11 +1,9 @@ | |||
| from typing import Generic, Literal, Union | |||
There was a problem hiding this comment.
Cleaning up unused imports.
mattgd
force-pushed
the
feature/dsync-1816-add-async-support-for-organizations
branch
from
48aa634
to
5231694
Compare
tribble
approved these changes
Aug 14, 2024
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| class TestAsyncOrganizations(OrganizationFixtures): |
There was a problem hiding this comment.
I know 😢 We need some more thought to strike the right balance between little repetition and and readability.
| @@ -75,29 +78,39 @@ def create_organization( | |||
| name: str, | |||
| domain_data: Optional[Sequence[DomainDataInput]] = None, | |||
| idempotency_key: Optional[str] = None, | |||
| ) -> Organization: ... | |||
| ) -> SyncOrAsync[Organization]: | |||
| """Create an organization | |||
There was a problem hiding this comment.
Odd. I wonder why this is in the diff Is it actually missing?
mattgd
deleted the
feature/dsync-1816-add-async-support-for-organizations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add async support for organizations. This is the last module I felt like async support could absolutely be useful, in tandem with other modules.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.