Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fga type updates #336

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Fga type updates #336

merged 2 commits into from
Aug 14, 2024

Conversation

tribble
Copy link

@tribble tribble commented Aug 14, 2024

Description

Update FGA to match our conventions:

  • Use duck types when possible
  • Use TypedDict for complex input types
  • Use string literals rather than enums
  • Re-export input types from the types module for convenience

Stacked on #335

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@tribble tribble marked this pull request as ready for review August 14, 2024 15:56
@tribble tribble requested a review from a team as a code owner August 14, 2024 15:56
@tribble tribble merged commit d4939fe into beta-5.0 Aug 14, 2024
5 checks passed
@tribble tribble deleted the fga-type-updates branch August 14, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants