Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more parameters for Exp ADBF. #101

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add more parameters for Exp ADBF. #101

wants to merge 4 commits into from

Conversation

huangxichen1
Copy link
Collaborator

This PR adds more parameters to the Exp-ADBF config, so that it can match with the Geometric-ADBF parameter settings.

y2m3y2m3 and others added 2 commits October 16, 2020 04:24
@y2m3y2m3
Finalize geometric bf config
44d5d8a 
 This will provide a better cardinality estimate and will be the finalized version
@huangxichen1
Add more parameters for Exp ADBF.
713b301
@huangxichen1
Copy link
Collaborator Author

huangxichen1 commented Oct 30, 2020 •
edited
Loading

@my2457 @AaronRanAn
Now I am setting the baseline branch as geo_bf_config_update_2 (PR #95) so as to show the additional change. I do not intend to merge this PR with PR #95. Instead, I will rebase it against the master branch after you merge PR #95 to the master. So please go ahead and merge PR #95 to the master once you are ready.

@huangxichen1 huangxichen1 changed the base branch from geo_bf_config_update_2 to master November 14, 2020 01:46
my2457
my2457 approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@my2457 my2457 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kungfucraig kungfucraig kungfucraig requested changes

@my2457 my2457 my2457 approved these changes

@AaronRanAn AaronRanAn Awaiting requested review from AaronRanAn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huangxichen1 @kungfucraig @my2457 @y2m3y2m3