Setup pre-commit hooks #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR sets up the pre-commit hooks configuration yaml file and adds the requirement to
pyproject.toml.CI should be enabled via: https://results.pre-commit.ci/repo/github/192398961
They say there is no setup beyond having the configuration yaml file and enabling the extension (see feature documentation).
Before merging let's decide on the specific styling and pre-commit hooks we want to enable.
Some options that have pre-commit hooks for Python are: autopep8, pylint, and flake8. I think this relates to this discussion: https://github.com/orgs/worldbank/discussions/6, as this is something that we'd be looking to standardize across at least the project, if not the wider "GOST" portfolio of projects.