-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate common messages #37
Open
TheButlah
wants to merge
7
commits into
main
Choose a base branch
from
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Deduplicate common messages #37
TheButlah
wants to merge
7
commits into
main
from
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
2 times, most recently
from
October 17, 2024 05:40
d7deafa
to
281c8d1
Compare
TheButlah
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
from
October 17, 2024 05:54
281c8d1
to
c439077
Compare
fouge
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
way nicer that it used to be!
TheButlah
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
2 times, most recently
from
October 17, 2024 19:40
ff9f0d7
to
9a11d83
Compare
TheButlah
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
from
October 17, 2024 19:41
9a11d83
to
8230d5f
Compare
fouge
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in mcu firmware and works well.
fouge
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
from
October 18, 2024 13:27
823cfc3
to
bd214e8
Compare
fouge
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
from
October 18, 2024 13:30
bd214e8
to
870a487
Compare
to make generation from Makefile in private repo works
fouge
force-pushed
the
ryanbutler-orbp-294-make-common-protobuf-messages-their-own-de-duplicated
branch
from
October 18, 2024 16:53
a3655d4
to
ba1d72c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the way we were compiling our protos resulted in duplicated rust structs for all messages in the common file.
I've reworked everything to use much more sensible file names, shorter module names, and most importantly, to unify the common types.