orb-ui: diamond: self-serve with cone support #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial cone support
fouge
force-pushed
the
fouge/orb-ui-diamond-self-serve
branch
from
706530b
to
b58e06c
Compare
fouge
force-pushed
the
fouge/orb-ui-cone
branch
from
58d3d45
to
ae6aa9d
Compare
Qbicz
reviewed
Aug 26, 2024
| std::thread::sleep(std::time::Duration::from_secs( | ||
| CONE_LED_STRIP_RAINBOW_PERIOD_S, | ||
| )); | ||
| counter = (counter + 1) % 6; |
There was a problem hiding this comment.
what about naming this magic 6? It will be easier to understand it's purpose ;)
fouge
force-pushed
the
fouge/orb-ui-cone
branch
3 times, most recently
from
9f3fe3c
to
7d90c4f
Compare
|
@fouge shall we rebase on main and mark as ready for review? |
|
@TheButlah i'm gonna have a look today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UX with cone in Diamond self-serve mode.
fixes ORBP-113