Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hil: add option for reusing existing rts #269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hil: add option for reusing existing rts #269

wants to merge 1 commit into from

Conversation

AlexKaravaev
Copy link
Contributor

s3 urls are unique for given commit, we might want to reuse them for gh workflows, but currently since we manipulate filename inside orb-hil we cannot supply correct rts-path (We can in theory but that's ugly)

TheButlah
TheButlah requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@TheButlah TheButlah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not add functionality that is brittle. Unless we perform a checksum validation on the file, and retrieve the canonical sha from s3, I don't think we should reuse any files.

Do you think you could look into implementing sha retrieval from s3?

@AlexKaravaev
Copy link
Contributor Author

yep, will do so. It should be fairly easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheButlah TheButlah TheButlah requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexKaravaev @TheButlah