-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tx with blobs #45
base: main
Are you sure you want to change the base?
Tx with blobs #45
Conversation
@@ -1,2 +0,0 @@ | |||
[registries.crates-io] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
src/broadcast_utils.rs
Outdated
|
||
let sidecar = sidecar.build()?; | ||
tx_request = tx_request | ||
.with_max_fee_per_blob_gas(max_fee_per_gas.low_u128()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be max_fee_per_blob_gas
that we have to estimate
src/tx_4844.rs
Outdated
@@ -0,0 +1,78 @@ | |||
#[cfg(test)] | |||
mod tests { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this tests is here and not under tests
?
No description provided.