Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimized verifier update #130

Merged
merged 22 commits into from
Sep 27, 2023
Merged

optimized verifier update #130

merged 22 commits into from
Sep 27, 2023

Conversation

dcbuild3r
Copy link
Collaborator

@dcbuild3r dcbuild3r commented Sep 13, 2023 •
edited
Loading

This PR includes:

  • Optimized verifier for insertions, deletions and inclusion proofs of tree depth 16 (!!!! Missing prod contracts !!!!)
  • tests that create real inputs on a mock tree and validates that proofs verify correctly
  • optimizations here and there
  • restructuring of tests and cleaning up function logic that is no longer needed in the V2

@dcbuild3r dcbuild3r added the enhancement New feature or request label Sep 13, 2023
@dcbuild3r
update test params and add docs
e06a177 
tests still break
@dcbuild3r
update verifiers
a6f59aa 
test fail
@dcbuild3r
fix incorrect import of insertion verifier for tests
6b1635d
@dcbuild3r
fix registration/deletion tests
44476b2
@dcbuild3r
delete all update logic and unused functions in V1
db8be57
@dcbuild3r
remove invalid commitment test
e8ff2fb 
we no longer need it because we make sure the commitments are valid off-chain within the circuit
@dcbuild3r
remove unreduced element test
85b3bc6 
we no longer need it because we make sure elements are reduced off-chain within the circuit
@dcbuild3r
fix tests
67d3bd3 
optimized verifier test still broken
@dcbuild3r
new optimized verifier
b6eb7c6 
test still broken
@dcbuild3r
fix interface errors
f869014 
proof invalid error
@dcbuild3r
fix optimized semaphore verifier test
892fc80
@dcbuild3r
add natspec explainer
5d86329
@dcbuild3r dcbuild3r marked this pull request as ready for review September 27, 2023 12:42
@dcbuild3r dcbuild3r merged commit 65105be into main Sep 27, 2023
1 check passed
@dcbuild3r dcbuild3r deleted the 0xkitsune/optimized-verifier branch September 27, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dzejkop Dzejkop Dzejkop left review comments

@0xKitsune 0xKitsune 0xKitsune approved these changes

Assignees

@0xKitsune 0xKitsune

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcbuild3r @Dzejkop @0xKitsune