fix typos

worldcoin · Sep 6, 2023 · 399dec2 · 399dec2
1 parent 66c899a
commit 399dec2
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/src/OpStateBridge.sol b/src/OpStateBridge.sol
@@ -66,8 +66,8 @@ contract OpStateBridge is Ownable2Step {
     /// @param _opGasLimit The new opGasLimit for sendRootOp
     event SetGasLimitPropagateRoot(uint32 _opGasLimit);
 
-    /// @notice Emmitted when the the StateBridge sets the gas limit for SetRootHistoryExpiryt
-    /// @param _opGasLimit The new opGasLimit for SetRootHistoryExpirytimism
+    /// @notice Emmitted when the the StateBridge sets the gas limit for SetRootHistoryExpiry
+    /// @param _opGasLimit The new opGasLimit for SetRootHistoryExpiryt
     event SetGasLimitSetRootHistoryExpiry(uint32 _opGasLimit);
 
     /// @notice Emmitted when the the StateBridge sets the gas limit for transferOwnershipOp

diff --git a/src/abstract/WorldIDBridge.sol b/src/abstract/WorldIDBridge.sol
@@ -156,7 +156,7 @@ abstract contract WorldIDBridge is IWorldID {
     /// @dev Note that a double-signaling check is not included here, and should be carried by the
     ///      caller.
     ///
-    /// @param root The of the Merkle tree
+    /// @param root The root of the Merkle tree
     /// @param signalHash A keccak256 hash of the Semaphore signal
     /// @param nullifierHash The nullifier hash
     /// @param externalNullifierHash A keccak256 hash of the external nullifier

diff --git a/src/test/PolygonStateBridge.t.sol b/src/test/PolygonStateBridge.t.sol
@@ -158,6 +158,30 @@ contract PolygonStateBridgeTest is PRBTest, StdCheats {
     ///                           REVERTS                           ///
     ///////////////////////////////////////////////////////////////////
 
+    /// @notice tests that the StateBridge contract can't be constructed with a zero address for params
+    function test_constructorParamsCannotBeZeroAddresses_reverts() public {
+        vm.expectRevert("WorldIDIdentityManager cannot be the zero address");
+        polygonStateBridge = new PolygonStateBridge(
+            checkpointManager,
+            fxRoot,
+            address(0)
+        );
+
+        vm.expectRevert("fxRoot cannot be the zero address");
+        polygonStateBridge = new PolygonStateBridge(
+            checkpointManager,
+            address(0),
+            mockWorldIDAddress
+        );
+
+        vm.expectRevert("checkpointManager cannot be the zero address");
+        polygonStateBridge = new PolygonStateBridge(
+            address(0),
+            fxRoot,
+            mockWorldIDAddress
+        );
+    }
+
     /// @notice tests that the StateBridge contract's ownership can't be changed by a non-owner
     /// @param newOwner The new owner of the StateBridge contract (foundry fuzz)
     function test_notOwner_transferOwnership_reverts(address nonOwner, address newOwner) public {