Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit review fixes #106

Merged
merged 17 commits into from
Sep 6, 2023
Merged

Audit review fixes #106

merged 17 commits into from
Sep 6, 2023

Conversation

dcbuild3r
Copy link
Collaborator

No description provided.

@dcbuild3r dcbuild3r added the bug Something isn't working label Sep 6, 2023
@dcbuild3r dcbuild3r self-assigned this Sep 6, 2023
src/OpStateBridge.sol Outdated Show resolved Hide resolved
src/OpStateBridge.sol Outdated Show resolved Hide resolved
src/OpStateBridge.sol Outdated Show resolved Hide resolved
src/OpStateBridge.sol Outdated Show resolved Hide resolved
src/OpStateBridge.sol Outdated Show resolved Hide resolved
@0xKitsune
Copy link
Contributor

0xKitsune commented Sep 6, 2023

In addition to the comments in the review, there are two additional minor issues I noticed.

  • There are a number of locations where "emitted" is spelled "emmitted", which we should fix.
  • This comment should be removed.

src/OpStateBridge.sol Outdated Show resolved Hide resolved
src/test/OpStateBridge.t.sol Outdated Show resolved Hide resolved
src/test/OpStateBridge.t.sol Outdated Show resolved Hide resolved
src/PolygonStateBridge.sol Outdated Show resolved Hide resolved
src/PolygonWorldID.sol Outdated Show resolved Hide resolved
src/OpStateBridge.sol Outdated Show resolved Hide resolved
@dcbuild3r dcbuild3r merged commit 5e65dd0 into main Sep 6, 2023
1 check passed
@dcbuild3r dcbuild3r deleted the dcbuild3r/audit-review-fixes branch September 6, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants