Display warning in plugin list info if plugin version is higher than expected

[thrijith]

Fixes #142

+------------------+----------+---------------------------------------+---------+
| name             | status   | update                                | version |
+------------------+----------+---------------------------------------+---------+
| akismet          | inactive | This version is higher than expected! | 999     |
| woocommerce      | inactive | available                             | 3.4.5   |
+------------------+----------+---------------------------------------+---------+

Theme List

+-----------------+----------+---------------------------------------+---------+
| name            | status   | update                                | version |
+-----------------+----------+---------------------------------------+---------+
| custom-theme    | inactive | none                                  | 1.0.26  |
| twentynineteen  | inactive | This version is higher than expected! | 1.5     |
| twentyseventeen | active   | available                             | 2.0     |
| twentysixteen   | inactive | none                                  | 1.9     |
+-----------------+----------+---------------------------------------+---------+

[thrijith]

PR is in draft as I couldn't find an any data of current theme version like plugin. For plugin that data is available in response's no_update . Is there any other option for theme?

[schlessera]

@thrijith The only thing I can think of right now is to go through the themes that state they don't provide an update and do an extra query to retrieve the latest version of these themes through the theme_information query:

[schlessera]

I flagged some mostly minor changes in here. The code in general looks good, but we need those tests to make sure it actually what we expect.

For testing, I think you're best bet is to assemble and load a small custom plugin snippet in Behat that uses the site_transient_update_plugins hook to modify the data that was retrieved from the API before running the command.

[thrijith]

@schlessera I have added a test for verifying the change. Please check and let me know if something needs change.

[schlessera]

A small reliability improvement, and then we're good to merge.

[schlessera]

I think this could potentially cause sporadic test failures where an update will be noticed after the installation step in line 555.

I think it would be better to do the following instead, without a prior check:

• unset ( $value->response['hello-dolly/hello.php'] ); (in case an actual update was found)
• $value->no_update['hello-dolly/hello.php']->new_version = '1.5'; to fake the versions as you already did.

This should always reliable trigger the error condition, if I've read the code correctly.

[schlessera]

Sorry for the back and forth, but I think there's still a logical flaw in there.

[schlessera]

Alright, let's merge this version now. We'll probably soon find out if we forgot something else now...;)

Thanks for the PR!

[wonderWomantotheResue]

Here's what I'm experiencing with wp cli v2.2.0 release 4/26. upon using wp theme list, I now see an error message next to themes by Elegant: MyResume, Minimal, Glow, and BlueSky. I see this:

BlueSky | inactive | version higher than expected | 5.0.12 | network

this error message is a false positive. The Elegant theme Blue sky is on current level today, 5.0.12 and does not need updating. Yet, wp cli thinks it needs updating. It happens with 4 of the Elegant themes we have installed on multi site. Something is out of sync. Plus the legend for the new version of wp theme status does not include U -update Available.

However, regarding the legend missing the definition for U -update Available seems to be appear as expected today. It looks like it was fixed. I just ran wp theme status today and the U = Update Available now exists.