feat: use *.asset.php for enqueued asset version and dependencies #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to generate the assets.php file - use the assets.php file for defining the version and dependencies (see: https://developer.wordpress.org/block-editor/getting-started/devenv/get-started-with-wp-scripts/#enqueuing-assets)
josephfusco
approved these changes
Feb 28, 2024
josephfusco
previously approved these changes
Feb 28, 2024
…use-asset.php # Conflicts: # package-lock.json # package.json # wpgraphql-ide.php
josephfusco
approved these changes
Feb 29, 2024
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wp-scripts will generate an assets.php file that tracks all of the WordPress dependencies used in the codebase (i.e.
@wordpress/element,@wordpress/data, etc) and outputs those dependencies in a PHP file that can be used to declare any dependencies that need to be loaded before our custom script is loaded.This allows us to add more
@wordpress/*packages in the future, or remove them if they're not needed, and not have to worry about manually updating thedependenciesarray inwp_enqueue_script().This also ensures that cache is busted when the build changes, as the version number is dynamically generated based on a build and not tied to a plugin version number.
closes #43
closes #53