Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is displayed when click 'Generate Missing Next-Gen Images Versions' while no optimization is selected #789

Closed
Mai-Saad opened this issue Feb 2, 2024 · 4 comments · Fixed by #805
Assignees
Labels
AVIF Avif branch/feature priority: high Issues which should be resolved as quickly as possible severity: major type: bug
Milestone

Comments

@Mai-Saad
Copy link

Mai-Saad commented Feb 2, 2024

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => Avif commit: b396de2
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
Error is displayed when clicking 'Generate Missing Next-Gen Images Versions'

To Reproduce
Steps to reproduce the behavior:

  1. Fresh activation of Imagify
  2. Click on 'Generate Missing Next-Gen Images Versions'

Expected behavior
WebP versions are generated while AVIF is not checked

Screenshots
Screenshot from 2024-02-02 08-22-27

Additional context
Add any other context about the problem here.

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

  • If AVIF is checked and we detect that there are missing AVIF images for optimized ones, we’ll create only AVIF versions for the images
  • If AVIF is not checked, we’ll create only Webp versions for the images
  • If filter is set to generate both AVIF/WebP, then both will be generated while AVIF option is checked
  • WebP generation won't consume quota
@Mai-Saad Mai-Saad added type: bug severity: major priority: high Issues which should be resolved as quickly as possible AVIF Avif branch/feature labels Feb 2, 2024
@Mai-Saad
Copy link
Author

Mai-Saad commented Feb 5, 2024

While AVIF is enabled can see this
Screenshot from 2024-02-05 12-17-33

@Mai-Saad
Copy link
Author

This error is there either AVIF enabled/disabled. @Tabrisrp can you please check? (tested on https://imagify.rocketlabsqa.ovh/)
Screenshot from 2024-02-23 04-31-11

Note:
when used clean local env, couldn't see the btn at all (even while having some images with the generate link in media library). Are you able to see it on clean local env? how?

@Tabrisrp
Copy link
Contributor

I updated the minified JS on the main branch, which was likely the issue here.

@Mai-Saad
Copy link
Author

No error now.
note: on new clean sites, it's very hard to see the generate btn now in settings page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AVIF Avif branch/feature priority: high Issues which should be resolved as quickly as possible severity: major type: bug
Projects
None yet
3 participants