Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #789 Fix error displayed when using generate missing next-gen versions button #805

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

Tabrisrp
Copy link
Contributor

Description

Remove avif as a supported mime type to prevent the error reported, as the format is not currently supported by the Imagick/GD implementation in WP (coming in 6.5).

Also update the ajax URL identifier for the generate missing next-gen versions in the JS file.

Fixes #789

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote self-explanatory code about what it does.
  • I named variables and functions explicitely.
  • I did not introduce unecessary complexity.

Observability

  • I handled errors when needed.

@Tabrisrp Tabrisrp added type: bug AVIF Avif branch/feature labels Feb 16, 2024
@Tabrisrp Tabrisrp added this to the 2.2 milestone Feb 16, 2024
@Tabrisrp Tabrisrp requested a review from a team February 16, 2024 20:04
@Tabrisrp Tabrisrp self-assigned this Feb 16, 2024
@Miraeld
Copy link
Contributor

Miraeld commented Feb 19, 2024

Shouldn't this file be modified/updated as well ?

@jeawhanlee
Copy link
Contributor

@Tabrisrp I did a small manual test with the PR branch and I got this error when I click on Generate missing next-gen images version:

Screenshot 2024-02-19 at 13 10 09

@Tabrisrp
Copy link
Contributor Author

I can't replicate it, did you have AVIF conversion enabled or not?

@jeawhanlee
Copy link
Contributor

I can't replicate it, did you have AVIF conversion enabled or not?

Avif was disabled when I checked this but with Avif enabled, I still get the error.

@piotrbak
Copy link

@jeawhanlee What kind of environment did you use? Was it a local or live one?

@jeawhanlee
Copy link
Contributor

@piotrbak A local

@piotrbak
Copy link

@Tabrisrp Are we okay with this comment made by @Miraeld?
#805 (comment)
If that's okay, let's move forward with CR.

@jeawhanlee let's see if QA will be able to reproduce this problem, if it's there we should also check if it's a regression when comparing to the current trunk version.

@Tabrisrp
Copy link
Contributor Author

Tabrisrp commented Feb 21, 2024

Yes it's fine we can update the minified files at the end

@Mai-Saad
Copy link

Mai-Saad commented Feb 22, 2024

@Tabrisrp Thanks for the PR. Got the same error mentioned by @jeawhanlee on both local and https://imagify.rocketlabsqa.ovh/ while AVIF is enabled or disabled. can you please check 🙏 (working fine on trunk)
Screenshot from 2024-02-22 14-41-00

@Tabrisrp
Copy link
Contributor Author

It might be related to the fixes done in #806

@Tabrisrp Tabrisrp merged commit 29f4bfb into feature/avif Feb 22, 2024
2 checks passed
@Tabrisrp Tabrisrp deleted the fix/789-generate-missing branch February 22, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AVIF Avif branch/feature type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error is displayed when click 'Generate Missing Next-Gen Images Versions' while no optimization is selected
5 participants