Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fix for the lightbox #762

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CrochetFeve0251
Copy link
Contributor

Description

Added a fix for the lightbox by not passing the wp attributes to the picture tag.

Fixes #758

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • This change requires a documentation update.

Is the solution different from the one proposed during the grooming?

No.

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

@CrochetFeve0251 CrochetFeve0251 self-assigned this Nov 22, 2023
@CrochetFeve0251 CrochetFeve0251 requested a review from a team November 22, 2023 11:07
@vmanthos vmanthos self-requested a review November 23, 2023 10:03
@vmanthos
Copy link
Contributor

@CrochetFeve0251 Thank you for the PR.

The issue has been fixed but there is a console error that's not there with trunk:

Uncaught TypeError: Cannot read properties of null (reading 'focus')

image

This can be seen here:
https://vasilis.rocketlabsqa.ovh/wordpress-6-4-lightbox-implementation

  1. Click on the jellyfish picture.
  2. Close the lightbox using the x button or the picture itself.
  3. Check the console log.

Can you please check this? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issue after WordPress 6.4 with the new lightbox functionality
3 participants