Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #763: AVIF support: UI #769

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Jan 3, 2024

Description

Some labels get changed from mentioning WebP to Next-gen images

Fixes #763

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@Miraeld Miraeld requested a review from a team January 3, 2024 02:48
@Miraeld Miraeld self-assigned this Jan 3, 2024
@jeawhanlee
Copy link
Contributor

@MathieuLamiot @piotrbak Does this need QA?

@MathieuLamiot
Copy link
Contributor

I don't think so

@jeawhanlee
Copy link
Contributor

Thanks @MathieuLamiot
We can merge this @Miraeld

@MathieuLamiot
Copy link
Contributor

@Miraeld Since this is related to a major release, I would recommend not merging into develop but a dedicated major branch. Otherwise, it would be included in the next minor version if any ; would that be OK @piotrbak ?

(cc @Tabrisrp )

@piotrbak
Copy link

piotrbak commented Jan 3, 2024

@MathieuLamiot Yes, we should have a separate branch for the major.

@Tabrisrp Tabrisrp changed the base branch from develop to feature/avif January 3, 2024 19:14
@Tabrisrp Tabrisrp merged commit f3c600a into feature/avif Jan 3, 2024
7 checks passed
@Tabrisrp Tabrisrp deleted the enhancement/763-avif-changes-ui branch January 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVIF support: UI
5 participants