Change methods name #785
Merged
Change methods name #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miraeld
reviewed
Jan 19, 2024
| @@ -202,20 +202,20 @@ protected function optimize_missing_sizes( $media_id, $context ) { | |||
| * @param string $context The context. | |||
| * @return bool|WP_Error True if successfully launched. A \WP_Error instance on failure. | |||
| */ | |||
| protected function generate_webp_versions( $media_id, $context ) { | |||
| protected function generate_nextgen_versions( $media_id, $context ) { | |||
There was a problem hiding this comment.
| @@ -27,8 +27,8 @@ class Imagify_Admin_Ajax_Post extends Imagify_Admin_Ajax_Post_Deprecated { | |||
| 'imagify_manual_optimize', | |||
| 'imagify_manual_reoptimize', | |||
| 'imagify_optimize_missing_sizes', | |||
| 'imagify_generate_webp_versions', | |||
| 'imagify_delete_webp_versions', | |||
| 'imagify_generate_nextgen_versions', | |||
There was a problem hiding this comment.
| * | ||
| * @since 1.7 | ||
| * | ||
| * @param object $item The current item. It must contain at least a $process property. | ||
| */ | ||
| protected function generate_webp_versions_button( $item ) { | ||
| protected function generate_nextgen_versions_button( $item ) { |
There was a problem hiding this comment.
| @@ -363,21 +363,21 @@ public function imagify_optimize_missing_sizes_callback() { | |||
| * | |||
| * @since 1.9 | |||
| */ | |||
| public function imagify_generate_webp_versions_callback() { | |||
| public function imagify_generate_nextgen_versions_callback() { | |||
There was a problem hiding this comment.
|
There is no need to re-assign it I think. |
|
This PR needs conflict fixed before moving forward |
Tabrisrp
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed methods name for media library view
Fixes #779
Type of change
Is the solution different from the one proposed during the grooming?
No
Please describe in this section if there is any change to the groomed solution, and why.
Checklists
Generic development checklist
Test summary