Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #803 Fix identifier for generate next-gen versions URL #804

Closed
wants to merge 3 commits into from

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented Feb 15, 2024

Description

Fix the identifier for generate next-gen versions URL, on edit image page and on images list.

This also fixes the link for deleting next-gen versions for images which are "already optimized".

Fixes #803

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote self-explanatory code about what it does.
  • I named variables and functions explicitely.
  • I did not introduce unecessary complexity.

@Tabrisrp Tabrisrp added type: bug AVIF Avif branch/feature labels Feb 15, 2024
@Tabrisrp Tabrisrp requested a review from a team February 15, 2024 21:24
@Tabrisrp Tabrisrp self-assigned this Feb 15, 2024
@Tabrisrp Tabrisrp added this to the 2.2 milestone Feb 15, 2024
@Tabrisrp Tabrisrp changed the base branch from develop to feature/avif February 15, 2024 21:24
Copy link
Contributor

@wordpressfan wordpressfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need to confirm that we don't need to deprecate the function get_imagify_attachment_delete_webp_versions_link

I believe it's hard to be used by end users as it requires the process object but wanted to double-check with u first, other than that, we are fine.

@Mai-Saad
Copy link

Mai-Saad commented Feb 20, 2024

Currently, the link is never displayed following the steps on main ticket. will block it till we fix when link is displayed.#792

Note:
The link is displayed on this commit 5d431cf with the following steps
1- on trunk, webP off
2- upload image
3- enable webp
4- check media library => generate webP is there
5- switch to commit above + dumpautoload
6- check media library => generate next-gen is there
7- switch to PR + dumpautoload => no generate link
@Tabrisrp can you please check?

@Tabrisrp
Copy link
Contributor Author

Closing in favor of #807 which contains the same changes

@Tabrisrp Tabrisrp closed this Feb 21, 2024
@Tabrisrp Tabrisrp deleted the fix/803-generate-nextgen-url branch February 21, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AVIF Avif branch/feature type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In edit image page if we click generate next-Gen image, we will be redirected to imagify settings page
4 participants