-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #796: Auto AVIF Convertion on settings save #811
Closes #796: Auto AVIF Convertion on settings save #811
Conversation
e32ea03
to
3674096
Compare
@Mai-Saad , So while trying to get back the IDs of unoptimized medias while running the bulk optimization, it wouldn't keep it as the backup file does not exists. To counter that issue, I've added the I've also taken care of the deletion of the image, when we delete the image, it will delete both backup, the original and the |
@Miraeld Thanks for the PR, now AVIF is created for large image with the following notes. |
@Miraeld Thanks for the update, compared to trunk and feature/avif branch, we will have regression here: |
@Miraeld Should it be moved to the QA again? Or it needs another CR? |
8fee66f
to
9731a75
Compare
9731a75
to
7ec715c
Compare
Umm, |
@Miraeld Thanks for the update.
|
Description
Fixes #796
Documentation
User documentation
When uploading images to wordpress, when the latest is over a certain dimension, WordPress will resize it and named it
-scaled
. Originally, we were doing a backup of the Original image, while on the bulk optimization it's trying to reach the-scaled
version as WordPress takes it as default.So we've added the
-scaled
version to be backed-up.Technical documentation
Before trying to save the
-scaled
version of the image in backup, we check if it exists. Same with the deletion of the image.Type of change
Checklists
Feature validation
Code style
Observability