Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #795: Compare original vs optimized image isnot working probably #814

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

jeawhanlee
Copy link
Contributor

Description

Fixes #795

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I did not introduce unecessary complexity.

@jeawhanlee jeawhanlee self-assigned this Feb 23, 2024
@jeawhanlee jeawhanlee requested a review from a team February 23, 2024 16:37
@Mai-Saad
Copy link

Mai-Saad commented Mar 3, 2024

@jeawhanlee Thanks for the PR. numbers are matching now. if UI is acceptable for product then we can merge this one /cc @piotrbak
Screenshot from 2024-03-03 16-40-07
Screenshot from 2024-03-03 16-39-19

@piotrbak
Copy link

piotrbak commented Mar 3, 2024

We're good here then

@Mai-Saad Mai-Saad added this pull request to the merge queue Mar 12, 2024
Merged via the queue into develop with commit 107f713 Mar 12, 2024
7 checks passed
@Mai-Saad Mai-Saad deleted the fix/795-compare-original-vs-optimized-image branch March 12, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare original vs optimized image isnot working probably
4 participants