Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #838: Fix the infinite loop of generate missing next-gen images #855

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Mar 13, 2024

Description

Fix an issue where "Generating missing next-gen files" was stuck in a loop.

Fixes #838

Documentation

User documentation

Webp will be automatically generated on settings save if AVIF is disabled.

Technical documentation

The bail-out avoiding the WebP auto-generation has been deleted.

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

@Miraeld Miraeld added the AVIF Avif branch/feature label Mar 13, 2024
@Miraeld Miraeld requested a review from a team March 13, 2024 13:50
@Miraeld Miraeld self-assigned this Mar 13, 2024
@Miraeld Miraeld added type: bug priority: medium Issues which are important, but no one will go out of business. labels Mar 13, 2024
@Miraeld Miraeld force-pushed the fix/838-missing-next-gen-infinite-loop branch from 44aff5d to 1cf8c34 Compare March 15, 2024 03:42
Copy link

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mai-Saad Mai-Saad added this pull request to the merge queue Mar 15, 2024
Merged via the queue into develop with commit 27710bd Mar 15, 2024
5 checks passed
@Mai-Saad Mai-Saad deleted the fix/838-missing-next-gen-infinite-loop branch March 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AVIF Avif branch/feature priority: medium Issues which are important, but no one will go out of business. type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate missing next-gen keeps loading in settings page without generating webP when disable avif
3 participants