Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #837: htaccess always modified when saving settings #861

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Mar 19, 2024

Description

Fixes #837

Documentation

User documentation

The .htaccess was always being modified while saving Imagify settings.
This PR fix this behavior to modify the .htaccess only when there is a change in the settings.

Technical documentation

We just check if the previous value is the same as the current one before changing the .htaccess.

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

@Miraeld Miraeld added the AVIF Avif branch/feature label Mar 19, 2024
@Miraeld Miraeld requested a review from a team March 19, 2024 06:34
@Miraeld Miraeld self-assigned this Mar 19, 2024
@Mai-Saad
Copy link

Copy link

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected
testrail-report-589.pdf

@Mai-Saad Mai-Saad added this pull request to the merge queue Mar 21, 2024
Merged via the queue into develop with commit a11a7c4 Mar 21, 2024
5 checks passed
@Mai-Saad Mai-Saad deleted the fix/837-htaccess-always-modified branch March 21, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AVIF Avif branch/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

htaccess is rewritten whenever we enable/disable avif or change settings
3 participants