Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #872 Prevent fatal error if returned extension value is false #873

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented Apr 4, 2024

Description

Prevent a fatal error when the returned extension value is false. Previous version was only handling string values, but wp_check_filetype() can return false.

Fixes #872

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@Tabrisrp Tabrisrp requested a review from a team April 4, 2024 18:17
@Tabrisrp Tabrisrp self-assigned this Apr 4, 2024
@Tabrisrp Tabrisrp added this pull request to the merge queue Apr 19, 2024
Merged via the queue into develop with commit a5b7820 Apr 19, 2024
5 checks passed
@Tabrisrp Tabrisrp deleted the fix/872-fatal-error branch April 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error during optimization process when unexpected extension
2 participants